Monitor: show Ollama's loaded models, their VRAM footprint, and busy state

The status snapshot now queries /api/ps (2s timeout so a wedged Ollama
cannot stall the channel) and the ollama line renders e.g.
'UP · llama3.1:8b (4.8 GiB VRAM) · busy'; comfy gets the busy marker
too while an image job runs.
This commit is contained in:
mram
2026-09-22 12:44:04 +02:00
parent e98331bb9e
commit d2c49e52fa
4 changed files with 112 additions and 25 deletions
+29 -5
View File
@@ -813,7 +813,7 @@ func run(ctx context.Context, cfg config.Config, log *slog.Logger, logOut io.Wri
// AUTO_UPDATE. // AUTO_UPDATE.
if isService { if isService {
serveControl(ctx, log, u, exePath, applyStaged, serveControl(ctx, log, u, exePath, applyStaged,
statusProvider(cfg, lk, comfySup, health, started, gw), statusProvider(cfg, lk, comfySup, health, started, gw, ollamaClient),
reloadHandler(cfg, configPath, restartWhenIdle)) reloadHandler(cfg, configPath, restartWhenIdle))
} }
@@ -1106,6 +1106,16 @@ type statusDownstream struct {
URL string `json:"url"` URL string `json:"url"`
Up bool `json:"up"` Up bool `json:"up"`
Managed string `json:"managed,omitempty"` Managed string `json:"managed,omitempty"`
// Models lists Ollama's loaded models with their VRAM footprint. Null
// when unknown (query failed / not applicable); [] means none loaded —
// deliberately no omitempty so the two stay distinguishable.
Models []statusModel `json:"models"`
}
// statusModel is one loaded Ollama model.
type statusModel struct {
Name string `json:"name"`
VRAMMB int64 `json:"vram_mb"` // 0 = resident in RAM, not VRAM
} }
type statusLock struct { type statusLock struct {
@@ -1183,8 +1193,10 @@ func diffConfig(a, b config.Config) []string {
return out return out
} }
// statusProvider assembles the one-line JSON snapshot for CmdStatus. // statusProvider assembles the one-line JSON snapshot for CmdStatus. The
func statusProvider(cfg config.Config, lk *lock.Lock, comfySup *supervise.Process, health *healthTracker, started time.Time, gw *gpuWatch) func() string { // loaded-model query to Ollama gets a short timeout so a wedged upstream
// cannot stall the status channel for long.
func statusProvider(cfg config.Config, lk *lock.Lock, comfySup *supervise.Process, health *healthTracker, started time.Time, gw *gpuWatch, ollamaClient *ollama.Client) func() string {
return func() string { return func() string {
snap := statusSnapshot{ snap := statusSnapshot{
Version: version, Version: version,
@@ -1197,9 +1209,21 @@ func statusProvider(cfg config.Config, lk *lock.Lock, comfySup *supervise.Proces
Foreign: foreign, AgeS: ageS, Foreign: foreign, AgeS: ageS,
} }
if cfg.OllamaURL != "" { if cfg.OllamaURL != "" {
snap.Downstreams = append(snap.Downstreams, statusDownstream{ d := statusDownstream{
Name: "ollama", URL: cfg.OllamaURL, Up: health.get("ollama"), Name: "ollama", URL: cfg.OllamaURL, Up: health.get("ollama"),
}) }
if ollamaClient != nil {
mctx, cancel := context.WithTimeout(context.Background(), 2*time.Second)
models, err := ollamaClient.LoadedModelDetails(mctx)
cancel()
if err == nil {
d.Models = make([]statusModel, 0, len(models))
for _, m := range models {
d.Models = append(d.Models, statusModel{Name: m.Name, VRAMMB: m.SizeVRAM / (1024 * 1024)})
}
}
}
snap.Downstreams = append(snap.Downstreams, d)
} }
if cfg.ComfyURL != "" { if cfg.ComfyURL != "" {
d := statusDownstream{Name: "comfy", URL: cfg.ComfyURL, Up: health.get("comfy")} d := statusDownstream{Name: "comfy", URL: cfg.ComfyURL, Up: health.get("comfy")}
+32 -9
View File
@@ -188,7 +188,9 @@ func renderMonitor(snap statusSnapshot, width int) string {
b.WriteString(cDim + " " + strings.Repeat("─", width-2) + cReset + "\x1b[K\n") b.WriteString(cDim + " " + strings.Repeat("─", width-2) + cReset + "\x1b[K\n")
for _, d := range snap.Downstreams { for _, d := range snap.Downstreams {
b.WriteString(renderDownstream(d) + "\x1b[K\n") busy := (d.Name == "ollama" && snap.Lock.State == "llm" && snap.Lock.LLMInflight > 0) ||
(d.Name == "comfy" && snap.Lock.State == "image")
b.WriteString(renderDownstream(d, busy) + "\x1b[K\n")
} }
b.WriteString("\x1b[K\n") b.WriteString("\x1b[K\n")
b.WriteString(renderLock(snap.Lock) + "\x1b[K\n") b.WriteString(renderLock(snap.Lock) + "\x1b[K\n")
@@ -227,25 +229,46 @@ func renderGPU(g statusGPU) string {
return s return s
} }
// renderVRAM renders "4.2 / 16.0 GiB used" (or MiB below 1 GiB). // formatMB renders MiB as "4.2 GiB" (or MiB below 1 GiB).
func renderVRAM(used, total int) string { func formatMB(mb int64) string {
format := func(mb int) string {
if mb >= 1024 { if mb >= 1024 {
return fmt.Sprintf("%.1f GiB", float64(mb)/1024) return fmt.Sprintf("%.1f GiB", float64(mb)/1024)
} }
return fmt.Sprintf("%d MiB", mb) return fmt.Sprintf("%d MiB", mb)
} }
// renderVRAM renders "4.2 / 16.0 GiB used" (or MiB below 1 GiB).
func renderVRAM(used, total int) string {
if total > 0 { if total > 0 {
return format(used) + " / " + format(total) + " used" return formatMB(int64(used)) + " / " + formatMB(int64(total)) + " used"
} }
return format(used) + " used" return formatMB(int64(used)) + " used"
} }
// printableLen counts characters without ANSI escapes (ASCII-only content). // printableLen counts characters without ANSI escapes (ASCII-only content).
func printableLen(s string) int { return len(s) } func printableLen(s string) int { return len(s) }
func renderDownstream(d statusDownstream) string { func renderDownstream(d statusDownstream, busy bool) string {
url := cDim + d.URL + cReset url := cDim + d.URL + cReset
detail := ""
if d.Models != nil {
if len(d.Models) == 0 {
detail = cDim + " · no models loaded" + cReset
} else {
parts := make([]string, 0, len(d.Models))
for _, m := range d.Models {
if m.VRAMMB > 0 {
parts = append(parts, fmt.Sprintf("%s (%s VRAM)", m.Name, formatMB(m.VRAMMB)))
} else {
parts = append(parts, m.Name+" (in RAM)")
}
}
detail = " · " + strings.Join(parts, ", ")
}
}
if busy {
detail += " · " + cCyan + "busy" + cReset
}
switch d.Managed { switch d.Managed {
case "stopped": case "stopped":
return fmt.Sprintf(" %s○%s %-8s %sstopped (managed — starts on demand)%s %s", return fmt.Sprintf(" %s○%s %-8s %sstopped (managed — starts on demand)%s %s",
@@ -259,7 +282,7 @@ func renderDownstream(d statusDownstream) string {
suffix = " (external)" suffix = " (external)"
} }
if d.Up { if d.Up {
return fmt.Sprintf(" %s●%s %-8s %sUP%s%s %s", cGreen, cReset, d.Name, cGreen, cReset, suffix, url) return fmt.Sprintf(" %s●%s %-8s %sUP%s%s%s %s", cGreen, cReset, d.Name, cGreen, cReset, suffix, detail, url)
} }
return fmt.Sprintf(" %s●%s %-8s %sDOWN%s %s", cRed, cReset, d.Name, cRed, cReset, url) return fmt.Sprintf(" %s●%s %-8s %sDOWN%s %s", cRed, cReset, d.Name, cRed, cReset, url)
} }
+19
View File
@@ -47,6 +47,25 @@ func TestRenderMonitor(t *testing.T) {
t.Errorf("frame missing %q:\n%s", want, frame) t.Errorf("frame missing %q:\n%s", want, frame)
} }
} }
snap.Downstreams[0].Models = []statusModel{{Name: "llama3.1:8b", VRAMMB: 4900}, {Name: "embed", VRAMMB: 0}}
snap.Lock = statusLock{State: "llm", LLMInflight: 1}
frame = renderMonitor(snap, 80)
for _, want := range []string{"llama3.1:8b (4.8 GiB VRAM)", "embed (in RAM)", "busy"} {
if !strings.Contains(frame, want) {
t.Errorf("frame missing %q:\n%s", want, frame)
}
}
snap.Downstreams[0].Models = []statusModel{}
snap.Lock = statusLock{State: "idle"}
frame = renderMonitor(snap, 80)
if !strings.Contains(frame, "no models loaded") {
t.Errorf("frame missing %q:\n%s", "no models loaded", frame)
}
if strings.Contains(frame, "busy") {
t.Errorf("idle lock still shows busy:\n%s", frame)
}
} }
func TestFmtDur(t *testing.T) { func TestFmtDur(t *testing.T) {
+28 -7
View File
@@ -62,11 +62,19 @@ type psResponse struct {
Models []struct { Models []struct {
Name string `json:"name"` Name string `json:"name"`
Model string `json:"model"` Model string `json:"model"`
SizeVRAM int64 `json:"size_vram"` // bytes resident in VRAM (0 = RAM-only)
} `json:"models"` } `json:"models"`
} }
// LoadedModels returns the names of models currently held in memory. // LoadedModel is one model currently held in memory.
func (c *Client) LoadedModels(ctx context.Context) ([]string, error) { type LoadedModel struct {
Name string
SizeVRAM int64 // bytes resident in VRAM; 0 when the model sits in RAM
}
// LoadedModelDetails returns the models currently held in memory with
// their VRAM footprint.
func (c *Client) LoadedModelDetails(ctx context.Context) ([]LoadedModel, error) {
req, err := http.NewRequestWithContext(ctx, http.MethodGet, c.base+"/api/ps", nil) req, err := http.NewRequestWithContext(ctx, http.MethodGet, c.base+"/api/ps", nil)
if err != nil { if err != nil {
return nil, err return nil, err
@@ -84,13 +92,26 @@ func (c *Client) LoadedModels(ctx context.Context) ([]string, error) {
if err := json.NewDecoder(resp.Body).Decode(&ps); err != nil { if err := json.NewDecoder(resp.Body).Decode(&ps); err != nil {
return nil, err return nil, err
} }
models := make([]string, 0, len(ps.Models)) models := make([]LoadedModel, 0, len(ps.Models))
for _, m := range ps.Models { for _, m := range ps.Models {
if m.Name != "" { name := m.Name
models = append(models, m.Name) if name == "" {
} else { name = m.Model
models = append(models, m.Model)
} }
models = append(models, LoadedModel{Name: name, SizeVRAM: m.SizeVRAM})
}
return models, nil
}
// LoadedModels returns the names of models currently held in memory.
func (c *Client) LoadedModels(ctx context.Context) ([]string, error) {
details, err := c.LoadedModelDetails(ctx)
if err != nil {
return nil, err
}
models := make([]string, 0, len(details))
for _, m := range details {
models = append(models, m.Name)
} }
return models, nil return models, nil
} }